On Wed, Jan 20, 2021 at 11:04:25AM -0500, Taylor Blau wrote: > From: Jacob Vosmaer <jacob@xxxxxxxxxx> > > Correctly initialize the "prefixes" strvec using strvec_init() instead > of simply zeroing it via the earlier memset(). > > There's no way to trigger a crash, since the first 'ref-prefix' command > will initialize the strvec via the 'ALLOC_GROW' in 'strvec_push_nodup()' > (the alloc and nr variables are already zero'd, so the call to > ALLOC_GROW is valid). For people not familiar with strvec, I think there's a missing bit of explanation between those two paragraphs: an initialized strvec does not point to NULL, but to a dummy array with a single NULL value in it. That explains why it might crash. :) That nit (and the one I mentioned in the previous patch) aside, these patches look good to me (and I am OK with or without the nits addressed). -Peff
