Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > Use "<file" instead of "< file", and don't put the closing quote for > strings on an indented line. This makes a follow-up refactoring commit > easier to read. > > Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> > --- > t/t9151-svn-mergeinfo.sh | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/t/t9151-svn-mergeinfo.sh b/t/t9151-svn-mergeinfo.sh > index 4f6c06ecb2..59c5847c5f 100755 > --- a/t/t9151-svn-mergeinfo.sh > +++ b/t/t9151-svn-mergeinfo.sh > @@ -9,37 +9,37 @@ test_description='git-svn svn mergeinfo properties' > > test_expect_success 'load svn dump' " > svnadmin load -q '$rawsvnrepo' \ > - < '$TEST_DIRECTORY/t9151/svn-mergeinfo.dump' && > + <'$TEST_DIRECTORY/t9151/svn-mergeinfo.dump' && This is not a new issue, but if $TEST_DIRECTORY or $rawsvnrepo have a funny character (like "'") in them, the above does not do the right thing. Everything would work much better, if swap dq and sq for the body, because these $variables _are_ visible in the body that is eval'ed. But you mentioned "a follow-up refactoring", so let's expect that things will get better in a later step. Thanks.
