Re: [PATCH v2] use delete_refs when deleting tags or branches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Elijah Newren <newren@xxxxxxxxx> writes:

> Overall, I like the patch.  Peff commented on v1 that the basic idea
> (use the part of the refs API that batches operations) is the right
> thing to do.

I concur; I agree with the general direction.

Where do we reject branch deletion based on the merged-ness?  When
we ask to delete three branches and one is not merged yet and cannot
be removed (let's say we are not "--force"ing) but the other two are
OK to remove, we do want the other two branches to go.  I didn't
check what the patch does with respect to this point, but as long as
the updated code does not make it "all or none", it would be great.

> I would say Reviewed-by, but I'd like to get Junio's comments on the
> return code and minor race.

It would have to wait a bit more.  Thanks for a review.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux