On 1/14/2021 9:36 PM, Derrick Stolee wrote: > On 1/14/2021 6:06 PM, Emily Shaffer wrote: >> On Fri, Jan 08, 2021 at 11:22:23AM -0800, Junio C Hamano wrote: >>> * ds/maintenance-part-4 (2021-01-05) 4 commits >>> (merged to 'next' on 2021-01-08 at 1f98c859ea) >>> + maintenance: use Windows scheduled tasks >>> + maintenance: use launchctl on macOS >>> + maintenance: include 'cron' details in docs >>> + maintenance: extract platform-specific scheduling >>> >>> Follow-up on the "maintenance part-3" which introduced scheduled >>> maintenance tasks to support platforms whose native scheduling >>> methods are not 'cron'. >>> >>> Will merge to 'master'. >> >> This series again has troubles running inside a directory with regex >> metachars in the path. Courtesy of Jonathan Nieder, I think this fix >> matches the intent a little better; but if we don't like this, the same >> lines could be diffed just to add --fixed-value instead. ... >> >> diff --git a/t/t7900-maintenance.sh b/t/t7900-maintenance.sh >> index 2e0c8a4c31..0edad63227 100755 >> --- a/t/t7900-maintenance.sh >> +++ b/t/t7900-maintenance.sh >> @@ -487,7 +487,9 @@ test_expect_success 'start and stop macOS maintenance' ' >> GIT_TEST_MAINT_SCHEDULER=launchctl:./print-args git maintenance start && >> >> # start registers the repo >> - git config --get --global maintenance.repo "$(pwd)" && >> + pwd >expect && >> + git config --get --global maintenance.repo >actual && >> + test_cmp expect actual && > > Sorry again, but this (and others) would probably be better as > > + git config --get --global --fixed-value maintenance.repo "$(pwd)" && Alternatively, the additional cases of "git config --get --global" in ds/maintenance-part-4 could actually be simply _removed_ because we are running all tests on all platforms. We already verify this behavior in the cron tests, such as 'start from empty cron table'. Thanks, -Stolee
