On Tue, Jan 12, 2021 at 04:45:47AM -0500, Jeff King wrote: > > The goal of this series is to remove direct access of the `struct > > revindex_entry` type, as well as `struct packed_git`'s `revindex` field. The > > on-disk format will be mmap'd and accessed directly, but the format is > > sufficiently different that the whole `revindex` array can't be written as-is. > > It looks good overall to me. I left a few nits around documentation and > integer types that I think are worth a re-roll, but I think after > addressing those it should be good. Thanks so much for your review. I think I addressed all of your feedback, but I'll sit on the revised patches for another day or so in case other reviewers would like to chime in before v2. Hopefully the this re-roll is the only one we'll need, since the next series is much more interesting! Thanks, Taylor
