On 1/8/2021 1:20 PM, Taylor Blau wrote: > Add a new option that unconditionally enables the pack.writeReverseIndex > setting in order to run the whole test suite in a mode that generates > on-disk reverse indexes. > > Once on-disk reverse indexes are proven out over several releases, we > can change the default value of that configuration to 'true', and drop > this patch. ... > +GIT_TEST_WRITE_REV_INDEX=<boolean>, when true enables the > +'pack.writeReverseIndex' setting. > + Should this also be added to the second run of the test suite with optional variables? diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh index 6c27b886b8f..d1cbf330a14 100755 --- a/ci/run-build-and-tests.sh +++ b/ci/run-build-and-tests.sh @@ -22,6 +22,7 @@ linux-gcc) export GIT_TEST_COMMIT_GRAPH_CHANGED_PATHS=1 export GIT_TEST_MULTI_PACK_INDEX=1 export GIT_TEST_ADD_I_USE_BUILTIN=1 + export GIT_TEST_WRITE_REV_INDEX=1 make test ;; linux-clang) Thanks, -Stolee