On Mon, Jan 11, 2021 at 12:09:27PM -0500, Derrick Stolee wrote: > > The reason I didn't pursue it here was that we haven't yet loaded the > > reverse index by this point. So, you'd want a function that at least > > stats the '*.rev' file (and either does or doesn't parse it [1]), or > > aborts early to indicate otherwise. > > In this patch, I would expect it to use sizeof(struct revindex_entry). > Later, the method would know if a .rev file exists and do the right > thing instead. (Also, should mmap'd data count towards this estimate?) Yeah, I think if we care about memory pressure, then the mmap would count anyway. I agree that letting the revindex code decide which to use would be the most accurate thing, but given that this whole chunk of code is an estimate (that does not even seem to take into account the memory used for the delta search!), I don't think it's worth trying to get to accurate. -Peff
