On Sat, Jan 9, 2021 at 5:48 AM Jeff King <peff@xxxxxxxx> wrote: > Commit 014ade7484 (upload-pack: send ERR packet for non-tip objects, > 2019-04-13) added a test that greps the output of a failed fetch to make > sure that upload-pack sent us the ERR packet we expected. But checking > this is racy; despite the argument in that commit, the client may still > be sending a "done" line when the server exits, causing it to die() on a > failed write() and never see the ERR packet at all. > [...] > So let's loosen to test to avoid annoying racy failures. If we s/to test to/the test to/ > eventually do the read-after-failed-write thing, we can tighten it. And > if not, v0 will grow increasingly obsolete as servers support v2, so the > utility of this test will decrease over time anyway. > > Note that we can still check stderr to make sure upload-pack bailed for > the reason we expected. It writes a similar message to stderr, and > because the server side is just another process connected by pipes, > we'll reliably see it. This would not be the case for git://, or for > ssh servers that do not relay stderr (e.g., GitHub's custom endpoint > does not). > > Helped-by: SZEDER Gábor <szeder.dev@xxxxxxxxx> > Signed-off-by: Jeff King <peff@xxxxxxxx>
