On 2007-08-21 17:58:45 +0200, Karl Hasselström wrote: > On 2007-08-21 14:23:29 +0100, Catalin Marinas wrote: > > > On 10/08/07, Karl Hasselström <kha@xxxxxxxxxxx> wrote: > > > > > diff --git a/t/t1000-branch-create.sh b/t/t1000-branch-create.sh > > > index cca5504..e920e93 100755 > > > --- a/t/t1000-branch-create.sh > > > +++ b/t/t1000-branch-create.sh > > > @@ -13,26 +13,9 @@ Exercises the "stg branch" commands. > > > stg init > > > > > > test_expect_success \ > > > - 'Create a spurious refs/patches/ entry' ' > > > - find .git -name foo | xargs rm -rf && > > > - touch .git/refs/patches/foo > > > > I haven't tried this test but is there any problem if we keep > > them? > > Yes. > > This test started to fail after my change. I don't remember exactly, > but I think it was git-symbolic-ref actually reading the file, > finding no ref there, and ignoring it. So this empty file didn't > mess up the machinery anymore, and since this isn't a common usecase > anyway, and since this change is to rely on git for all the > low-level ref manipulation, I just deleted the test. BTW, I just saw that this was explained by the second bullet point in the commit message. :-) -- Karl Hasselström, kha@xxxxxxxxxxx www.treskal.com/kalle - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html