Re: Patchwork instance "Submitter" attribution and GitGitGadget

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Konst,

On Thu, 7 Jan 2021, Konstantin Ryabitsev wrote:

> On Thu, Jan 07, 2021 at 03:35:54PM +0100, Johannes Schindelin wrote:
> > > Would it help to use the "Sender:" header?  IIUC right now GGG
> > > records its name on "From:" with its e-mail and a human-readable
> > > name derived from the author of the ptach, but if it can record the
> > > true author on "From:" and leave GGG's name on the "Sender:", would
> > > patchwork use the "From:" side of the identity instead?
> >
> > To tie up that loose end: GMail seemed to insist in my tests on replacing
> > the `From:` header, therefore we cannot implement this `Sender:` idea, not
> > using GMail to deliver the GitGitGadget patch series at least.
>
> Can you possibly set X-Original-From: in the header?

Potentially. But unfortunately, I am too short on time to perform such
experiments right now. And it is always subject to the question what GMail
does with this header in the future. `Sender:` used to work IIRC, but now
it doesn't.

> Patchwork almost does the right thing with it, though right now it
> expects that the From: will be set to the list's email address (which is
> only correct for google groups).
>
> We have a workaround for the current situation on patchwork.kernel.org [1],
> but it requires parsing the body of the message instead of just relying on the
> headers.
>
> > > If that works, it would have an additional benefit of not having to
> > > add the in-body "From:" to override the mail-header "From:", to avoid
> > > attributing the authorship to GGG.
>
> Using the in-body From: is both good and proper for such service. Trying to
> put the author's email into the actual From will run afoul of SPF.

Indeed.

Therefore, I would prefer to keep doing that in GitGitGadget: send from
its regular email address, and add the contributor's info in-body.

Ciao,
Johannes

>
> -K
>
> [1] https://git.kernel.org/pub/scm/infra/patchwork/procmail.git/tree/git.rc
>




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux