On Fri, Jan 8, 2021 at 2:38 AM Rafael Silva <rafaeloliveira.cs@xxxxxxxxx> wrote: > Eric Sunshine writes: > > On Mon, Jan 4, 2021 at 11:22 AM Rafael Silva > > <rafaeloliveira.cs@xxxxxxxxx> wrote: > >> The fifth patch adds worktree_escape_reason() that accepts a (char *) > >> text and returned the text with any LF or CRLF escaped. [...] > > > > Perhaps I misunderstand, but I had envisioned employing one of the > > codebase's existing quoting/escaping functions rather than crafting a > > new one from scratch. However, I'll reserve judgment until I actually > > read the patch. > > Agreed. It make sense to reuse one of the already implemented functions > from the code base. for some reason I was not able to find it. I believe > this was cleared out in one of the patches replies by you and Phillip Wood. No need to apologize. It's a big project and it can be difficult to discover existing utility functions. Fortunately, reviewers can often point out useful alternatives.
