Alban Gruin <alban.gruin@xxxxxxxxx> writes: > We had the same discussion with Phillip, who pointed out this previous > discussion about this topic: > https://lore.kernel.org/git/xmqqblv5kr9u.fsf@xxxxxxxxxxxxxxxxxxxxxxxxx/ > > So, it's probably OK to do that. These days, there exists an optional installation option exists that won't even install built-in commands in $GIT_EXEC_PATH, which invalidates the assessment made in 2019 in the article you cited above, so the code might still be OK, but the old justification no longer would apply. In any case, if two people who reviewed a patch found the same thing in it fishy, it is an indication that the reason why the apparently fishy code is OK needs to be better explained so that future readers of the code do not have to be puzzled about the same thing. Thanks.
