Hi Junio, On Mon, 28 Dec 2020, Junio C Hamano wrote: > * ss/submodule-add-in-c (2020-12-15) 3 commits > . t7400: add test to check 'submodule add' for tracked paths > . submodule: port submodule subcommand 'add' from shell to C > . dir: change the scope of function 'directory_exists_in_index()' > > "git submodule add" being rewritten in C. > > Expecting a reroll. > The patches are split incorrectly; part of 1/3 belongs to 2/3 > cf. <nycvar.QRO.7.76.6.2012190104140.56@xxxxxxxxxxxxxxxxx> > It seems to introduce a segfault on 'seen'. > cf. <xmqqft3xflw7.fsf@xxxxxxxxxxxxxxxxxxxxxx> Maybe nycvar.QRO.7.76.6.2012190104140.56@xxxxxxxxxxxxxxxxx would be a better reference, as I diagnosed this issue and provided a patch that papers over the issue (hoping that the original contributor would not take it as-is). Ciao, Dscho
