On Sat, 2 Jan 2021 at 18:43, Thomas Ackermann via GitGitGadget
<gitgitgadget@xxxxxxxxx> wrote:
[Snip several typo fixes in Documentation/, all of which I agree with.]
> diff --git a/contrib/buildsystems/CMakeLists.txt b/contrib/buildsystems/CMakeLists.txt
> index c151dd7257f..8f77baa678f 100644
> --- a/contrib/buildsystems/CMakeLists.txt
> +++ b/contrib/buildsystems/CMakeLists.txt
Hmm... This does not match the "doc:" prefix of the patch.
> @@ -442,7 +442,7 @@ endif()
> check_c_source_compiles("
> #include <regex.h>
> #ifndef REG_STARTEND
> -#error oops we dont have it
> +#error oops we don't have it
> #endif
I don't think this is correct. This omission of the single quote somehow
looks like it's done on purpose. I don't build using this system, but I
tried making some silly code like this in another file, which I actually
do use:
#if 0
#error might or mightn't work
#endif
My compiler refused to compile: "error: missing terminating ' character
[-Werror]". So I fear this change to CMakeLists.txt would make us
needlessly fail to autodetect whatever it is we're looking for here.
If this change to CMakeLists.txt is dropped, this patch looks good
to me.
Martin
