Hi Junio, On Mon, 21 Dec 2020, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > -- snipsnap -- > > From e8ce19db04657b6ef1c73989695c97a773a9c001 Mon Sep 17 00:00:00 2001 > > From: Johannes Schindelin <johannes.schindelin@xxxxxx> > > Date: Fri, 28 Aug 2020 14:50:25 +0200 > > Subject: [PATCH] fixup??? git: catch an attempt to run "git-foo" > > > > This is needed to handle the case where `argv[0]` contains the full path > > (which is the case on Windows) and the suffix `.exe` (which is also the > > case on Windows). > > > > Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx> > > --- > > git.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/git.c b/git.c > > index 7544d2187306..c924c53ea76f 100644 > > --- a/git.c > > +++ b/git.c > > @@ -854,6 +854,7 @@ int cmd_main(int argc, const char **argv) > > const char *cmd; > > int done_help = 0; > > > > + strip_extension(argv); > > cmd = argv[0]; > > Hph, would this make strip_extension() at the beginning of > handle_builtin() redundant and unneeded, I wonder? I poured over this for a couple minutes, and I think you're right. > Yes, I know stripping .exe twice would be fine most of the time, so > I'll queue the patch on top just to make 'seen' pass the tests, but > it is just as easy to discard jc/war-on-dashed-git topic, so... I dunno. There is probably value in starting the deprecation for realz. I mean, we deprecated dashed commands, like, an age ago (2020 alone felt like a century, didn't it?). Maybe it is time to warn about using dashed commands now. We could even consider "brown-outs" at some stage, via a pseudo-random condition that triggers rarely in spring 2021 but incrementally frequently over time? Ciao, Dscho
