Re: [PATCH 1/2] test: completion: add tests for __git_complete

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Denton Liu wrote:
> Hi Felipe,
> 
> On Mon, Dec 28, 2020 at 01:23:01PM -0600, Felipe Contreras wrote:
> > Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx>
> > ---
> >  t/t9902-completion.sh | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
> > index a1c4f1f6d4..2e59fe4de0 100755
> > --- a/t/t9902-completion.sh
> > +++ b/t/t9902-completion.sh
> > @@ -2380,4 +2380,11 @@ test_expect_success 'sourcing the completion script clears cached --options' '
> >  	verbose test -z "$__gitcomp_builtin_notes_edit"
> >  '
> >  
> > +test_expect_success '__git_complete' '
> > +	__git_complete foo __git_main &&
> > +	test "$(type -t __git_wrap__git_main)" == function &&
> 
> s/==/=/ for this and the other patch.

Sure, I'll include that in the next version.

But I expect people will make further comments on the whole method to
find out if a function exists.

-- 
Felipe Contreras



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux