Junio C Hamano wrote: > Also, instead of relaying as-is, you can relay a patch with your > improvements rolled into the same patch (i.e. not as follow-up > fixes). Some (or major) parts of the original patch may still > remain in the edited result and you'd need to keep original author's > sign-off as-is [*1*]. Yes, you *can*, but doing so in this case would be against the author's wishes, and a violation of the Developer Certificate of Origin. > In this topic's case, 2/2 would be a feature enhancement on top of > 1/2, so relaying 1/2 as-is would be OK, but in a case where an > promising patch was sent with sign-off and bugs, then gets abandoned > by the original author, fixing the bug in the patch you relay in > place (i.e. not as follow-up patches) may even be necessary to keep > bisectability. When you do so, you'd typically do: If the author doesn't object (which is usually the case), this makes sense. But if the author objects, you would be violating clause (d) of the DCO. Just because the only way to do X is to violate laws, terms, or agreements doesn't mean that's what you should do. You can simply not do X. -- Felipe Contreras
