Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: >> > But I'm not going to pretend I'm fine with a change I disagree with; I'm >> > not. Especially when nobody is paying me to do this. >> ... >> >> The community needs to do its part in making you and everyone else >> >> feel welcome. At the same time you need to do your part in making >> >> contributors, especially the new ones, feel welcome and appreciated. >> >> Being overly critical can turn developers away from the project. >> > >> > Who are you talking about? I'm the one who made the contribution. >> >> What does the "change you disagree with" you mention above refer to? >> Changes suggested by reviewers to add per-tool knob? > > Yes. If so, please realize that this is a team effort. You are not THE one making contribution. Everybody else also is. You are building on top of others' code, others are helping you to improve your patches with their input, and others can and will later build on top of what you have done. If you are not fine with a change others will make on top of what you did, well, tough. It's not like by sending a patch you lick a corner of the cake and make it untouchable by others. Just as you said, you can agree to disagree and move on. Once a rough concensus is reached that the work on top of what you did is a good direction to go, it would not get us anywhere to repeat the same opinion over and over again to block it.
