On Wed, 23 Dec 2020 at 04:51, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > > On Tue, Dec 22, 2020 at 5:47 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Martin Ågren <martin.agren@xxxxxxxxx> writes: > > > +test_expect_success 'stop preserves surrounding schedule' ' > > > + echo "Crucial information!" >>cron.txt && > > > + GIT_TEST_CRONTAB="test-tool crontab cron.txt" git maintenance stop && > > > > 31345d55 (maintenance: extract platform-specific scheduling, > > 2020-11-24) in ds/maintenance-part-4 needs to adjust this > > exported variable for the tests to pass in 'seen' > > > > Is it just the matter of replacing it with > > GIT_TEST_MAINT_SCHEDULER="crontab:test-tool crontab ..." > > or is there more to it? Oh, I never realized this could be a problem. My merge with seen had a textual conflict, but nothing difficult, and the tests passed, so I didn't even stop to think if there was more to it. I clearly didn't notice the environment variable changed both name and value. > Yes, renaming GIT_TEST_CRONTAB to GIT_TEST_MAINT_SCHEDULER and > prepending "crontab:" to the value should be sufficient (per the > proposal by [1] and realization by [2]). > > [1]: https://lore.kernel.org/git/X6+iJNYEbpQjHCb0@flurp.local/ > [2]: https://lore.kernel.org/git/4807342b0019be29bb369ed3403a485f0ce9c15d.1605647598.git.gitgitgadget@xxxxxxxxx/ Thanks Junio and Eric for helping out. Martin
