Sergey Organov wrote: > While we are at it, Linux kernel developers care enough about style to > provide script that checks patch series for issues and to insist it is > run before submitting. > > I've used this script to cleanup these series for the next re-roll and I > think that having semi-automated test makes a lot of sense, so you may > wish to consider to adopt it for Git as well (it seems to have some > requirements that are not enforced for Git sources, but not many). > > The script is called scripts/checkpatch.pl in the Linux kernel sources. Yeah, this has been suggested before. It would make the job of newcomers that haven't learned the style yet much easier. And also it would make suggestions about the style of patches a bit less subjective. Cheers. -- Felipe Contreras