Hey everyone, Here's my second blog post on "everybody struggles". https://sangu09.github.io/everybody-struggles/ Do give it a read let me know if you have any suggestions. Thanks and Regards, Sangeeta On Fri, Dec 4, 2020 at 2:08 PM Kaartic Sivaraam <kaartic.sivaraam@xxxxxxxxx> wrote: > > Hi Sangeeta, > > On 03/12/20 4:27 pm, Sangeeta wrote: > > > > First of all thanks for the feedback! I have made the changes. > > > > Secondly, regarding the microproject, it is still under review and I > > read that in the mail[1](What's cooking in Git)(you can search for > > "untracked" in the mail), Junio states that it is left on some changes > > which I have already made in patch 7[2]. What is stopping me to reply > > to that mail is that I might not have answers to some of the questions > > that Danh asked[3](Should this change applicable to diff-index, > > diff-files and other plumbing commands?) because I don't know whether > > that would be breaking changes or not. I tried to test it in my local > > and I found everything was working fine as expected but I don't know > > the reason for that nor do I know the reason for whether things should > > break or not. > > > Thanks for checking. Don't hesitate to reply to Danh's e-mail with what > you've done and what you're not certain about. It's a good way to move > things forward. Also, you could try Cc-ing people who seem to have > worked in the diff code recently. For instance using `git log` to see > the people who've modified the diff.c and `wt-status.c` recently, I > could observe that: > > Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> > > Elijah Newren <newren@xxxxxxxxx> > > Jeff King <peff@xxxxxxxx> > > are some contributes who might be able to provide you some inputs. > > > [1] https://lore.kernel.org/git/xmqqtut6qf7q.fsf@xxxxxxxxxxxxxxxxxxxxxx/ > > [2] https://lore.kernel.org/git/20201110083900.88161-1-sangunb09@xxxxxxxxx/ > > [3] https://lore.kernel.org/git/X6rJWpuUHz1qHYZL@xxxxxxxx/ > > > > To give you a context of my changes, I have made > > `--ignore-submodules=untracked` the default for `git diff` when there > > is no configuration variable or command-line option, to ensure that > > the command doesn't give '-dirty' suffix to a submodule whose working > > tree has untracked files. This was done to make it consistent with > > `git describe`. For this, I had to make a global variable to check > > whether ignoreSubmodules is set or not in the user config so that it > > doesn't override that. Also to ensure that `git status` remains the > > same, I have made `--ignore-submodules=none` the default for `git > > status` so that the user doesn't end up deleting a submodule that has > > uncommitted (untracked) files. > > > > Also, thanks for the helpful summary! > > -- > Sivaraam
