Hi, On 17/12/20 08:45PM, Johannes Sixt wrote: > Am 01.11.20 um 18:05 schrieb Stefan Haller: > > Do an automatic rescan whenever the git-gui window receives focus. Most other > > GUI tools do this, and it's very convenient; no more pressing F5 manually. > > > > People who don't like this behavior can turn it off using > > "git config gui.autorescan false". > > > > Stefan Haller (2): > > git-gui: Delay rescan until idle time > > git-gui: Auto-rescan on activate > > > > git-gui.sh | 26 ++++++++++++++++++++++---- > > 1 file changed, 22 insertions(+), 4 deletions(-) > > > > I've been using these patches in the past days. > > I am still a bit ambivalent on whether I like the behavior. I do switch > among windows *a lot* and there is a short flicker on every rescan. And > there is muscle memory... This is part of the reason I am a little uneasy enabling it by default, and why I insist on having a loud and clear warning to the users about what is going on. > I observe a bug and a half: > > It is unclear which file is selected automatically when there are > unstaged changes. But there is one misbehavior: after I have invoked the > merge tool, resolved the conflict, and then switch back to Git GUI, the > conflicted file is not selected anymore when it is not the first file in > the list. That is *very* annoying. Haven't had a chance to try this out yet but AFAIK the last file should be correctly remembered. See below. > And then there is the following use-case. While Git GUI is not active > (think Git GUI and Gitk side-by-side and Gitk active), I click on a > particular file that is not at the top of the list; then Git GUI becomes > active and rescans, but also forgets on which file I have clicked. But I > expected the clicked-on file to become visible, which it doesn't, and I > have to click again. This is mildly annoying. Hmm, I don't see that on my system on Linux. The code to remember last open file is there in 'rescan_done'. So I don't understand why this becomes a problem on your system. -- Regards, Pratyush Yadav
