On Tue, Dec 15, 2020 at 04:56:18PM -0800, Junio C Hamano wrote: > > Josh Steadmon <steadmon@xxxxxxxxxx> writes: > > > On 2020.12.04 17:45, Emily Shaffer wrote: > >> Hi folks, and thanks for the patience - I ran into many, many last-mile > >> challenges. > >> > >> I haven't addressed many comments on the design doc yet - I was keen to get the > >> "functionally complete" implementation and conversion to the list. > >> > >> Next on my plate: > >> - Update the design doc to make sense with what's in the implementation. > >> - A blog post! How to set up new hooks, why they're neat, etc. > >> - We seem to have some Googlers interested in trying it out internally, so > >> I'm hoping we'll gather and collate feedback from that soon too. > >> - And of course addressing comments on this series. > >> > >> Thanks! > >> - Emily > > > > This approach looks good to me. I'll look forward to seeing the updated > > design and the feedback from the internal tests. > > Thanks. > > By the way, es/config-hooks does not seem to pass 5411 (at least) > even as a standalone topic, and has been kicked out of 'seen' for > some time. Has anybody took a look into the issue? Yeah, I looked at it today. Looks like an issue with not paying attention to master->main default config, since I added a new test to the 5411 suite (which means it wouldn't have made a conflict for someone to say "ah yes, s/master/main/g"). I am tracking down couple of other CI errors today and will send a reroll today or tomorrow.
