On 12/14/2020 11:21 AM, Elijah Newren via GitGitGadget wrote: > This series builds on en/merge-ort-2 and adds basic rename detection to > merge-ort. I have now finished a full pass through this series. I find it to be well organized with a satisfying conclusion. My comments are mostly about nits. I tried to recommend some better organization, but failed to find a clear way to do so, which shows that the organization here is sound. My only complaint is that some of the patches break compilation, so that should definitely be fixed to assist with bisects in the future (likely for bisects unrelated to this feature). Thanks, -Stolee