On 07/12/2020 03:21, Felipe Contreras wrote: > On Sun, Dec 6, 2020 at 6:35 PM Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> wrote: [snip] >> Notice that the 'clean' target is making a nested call to the parent >> Makefile to ensure that the GIT-VERSION-FILE is up-to-date (prior to >> the previous patch, there would have been _two_ such invocations). >> This is to ensure that the $(GIT_VERSION) make variable is set, once >> that file had been included. However, the 'clean' target does not use >> the $(GIT_VERSION) variable, so this is wasted effort. > > Yes, this is the important information: "the 'clean' target does not use > the $(GIT_VERSION) variable". I would feature it at the start of the > commit message. Heh, I didn't intend to 'bury the lead' here. I spent about 30 minutes re-writing this message to come up with an improvement; I'm not sure that I succeeded. ;-) v3 comming soon ... Thanks! ATB, Ramsay Jones
