On Tue, Dec 08, 2020 at 12:06:49PM -0800, Jonathan Tan wrote: > > I would worry how clients handle this bogus entry in the ref > > advertisement. It looks like the actual Git client is OK, but what about > > jgit, libgit2, etc? That's not necessarily a deal-breaker, but it would > > be nice to know how they react. > > That bogus entry is defined in the protocol and JGit both produces and > consumes that line. Consumption was verified by patching Git with my > patch and running the following commands in separate terminals: Ah, indeed. I forgot that we went through all of this a few years ago for your eb398797cd (connect: advertized capability is not a ref, 2016-09-09). I stand behind the "it was probably originally an error in the protocol documentation" from [1], but at this point I think we can say it's a supported part of the protocol. All of this is moot, of course, if we only do the v2 solution. :) -Peff [1] https://lore.kernel.org/git/20160902233547.mzgluioc7hhabalw@xxxxxxxxxxxxxxxxxxxxx/
