On Thu, Dec 03, 2020 at 02:00:50PM -0800, Junio C Hamano wrote: > "Derrick Stolee via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > > > From: Derrick Stolee <dstolee@xxxxxxxxxxxxx> > > > > When calculating the sizes of certain chunks, we should use 64-bit > > multiplication always. This allows us to properly predict the chunk > > sizes without risk of overflow. > > That's quite an obvious fix, applicable even before this entire > series. I think we saw quite similar bugfixes in different parts of > the codebase recently. :-). Indeed, Stolee and I were probably looking at output from the same static analysis tool, which seems to be eager to catch these sorts of multiplication-widening errors. I'd be happy to see this patch get applied down regardless of what happens with the rest of the series. Thanks, Taylor
