On Fri, Dec 04, 2020 at 01:54:31PM -0800, Junio C Hamano wrote: > >> +static inline size_t oid_array_next_unique(struct oid_array *array, size_t cur) > > Perhaps the function can make it clear that it expects to be fed a > sorted array in its name, which would be even better? The name is already pretty clunky. I'm not thrilled with the idea of making it even longer. :) IMHO it's unlikely for somebody to stumble on it and not read the comment or look at an existing call, if only because the function you'd probably reach for immediately is more like oid_array_for_each_unique(). -Peff
