Re: [PATCH v2 23/24] pack-bitmap-write: relax unique rewalk condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 07, 2020 at 10:19:09AM -0800, Jonathan Tan wrote:

> Quoting from the next patch [1]:
> 
> >              |   runtime (sec)    |   peak heap (GB)   |
> >              |                    |                    |
> >              |   from  |   with   |   from  |   with   |
> >              | scratch | existing | scratch | existing |
> >   -----------+---------+----------+---------+-----------
> >   last patch | 100.641 |   35.560 |   2.152 |    2.224 |
> >   this patch |  99.720 |   11.696 |   2.152 |    2.217 |
> 
> That is true, but it is not ameliorated much :-(
> 
> If you have steps to generate these timings, I would like to try
> comparing the performance between all patches and all-except-23.

Yes, the drop in CPU performance is disappointing. And there may be a
better way of selecting the commits that recovers some of it.

But all-except-23 is not workable from a memory usage perspective.
Originally we did not have that commit at all, and a full repack of our
git/git fork network (i.e., all forks stuffed into one alternates repo)
went from 16GB to OOM-ing after growing 80+GB (I don't know how large it
would have gone on a bigger machine).

-Peff



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux