Re: [PATCH v4 04/19] convert: add conv_attrs classification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 4, 2020 at 9:33 PM Matheus Tavares
<matheus.bernardino@xxxxxx> wrote:
>
> From: Jeff Hostetler <jeffhost@xxxxxxxxxxxxx>
>
> Create `enum conv_attrs_classification` to express the different ways
> that attributes are handled for a blob during checkout.

Micronit: the subject of the patch might want to be a bit more
explicit like "convert: add conv_attrs_classification enum". Otherwise
it could make one wonder if it is missing an underscore between
"conv_attrs" and "classification".

> This will be used in a later commit when deciding whether to add a file
> to the parallel or delayed queue during checkout. For now, we can also
> use it in get_stream_filter_ca() to simplify the function (as the
> classifying logic is the same).
>
> Signed-off-by: Jeff Hostetler <jeffhost@xxxxxxxxxxxxx>
> [matheus.bernardino: use classification in get_stream_filter_ca()]

Maybe "Co-authored-by: Matheus Tavares <matheus.bernardino@xxxxxx>" instead?

> Signed-off-by: Matheus Tavares <matheus.bernardino@xxxxxx>



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux