On Fri, Dec 04, 2020 at 07:33:56PM +0000, Johannes Schindelin via GitGitGadget wrote: > In 0a21d0e08902 (Makefile: mark git-maintenance as a builtin, > 2020-12-01), we marked git-maintenance as a builtin in the Makefile, but > forgot to do the same in `CMakeLists.txt`. Oof, right. > Rather than always play catch-up and adjust `git_builtin_extra` > manually, use the `BUILT_INS` definitions in the Makefile as > authoritative source and generate `git_builtin_extra` dynamically. Yay. This is exactly how I'd hoped things would work or the cmake file in general. I don't mind following micro-formats within our Makefile to keep things easier for the cmake parsing side. > contrib/buildsystems/CMakeLists.txt | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) The implementation looks plausibly correct to me (bearing in mind that I've never written cmake). -Peff
