On 12/4/2020 1:56 PM, Jeff King wrote:
> That turns out not to be a problem, though. The only things we do with
> the count are:
>
> - check if our count will overflow our data structures. But the limit
> there is 2^31 commits, so it's not likely to happen in practice.
You do point out that you are removing this logic, done in this
if statement:
> - if (count_distinct >= GRAPH_EDGE_LAST_MASK) {
> - error(_("the commit graph format cannot write %d commits"), count_distinct);
> - res = -1;
> - goto cleanup;
> - }
What is the harm of keeping this? I know it is very unlikely, but
I'd rather fail here than write a commit-graph that gets parsed as
garbage.
Thanks,
-Stolee
