On 12/3/2020 4:50 PM, Junio C Hamano wrote: > "Derrick Stolee via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > >> From: Derrick Stolee <dstolee@xxxxxxxxxxxxx> > >> Subject: Re: [PATCH 08/15] midx: convert chunk write methods to return int > > Please rephrase the title to avoid misleading the readers; it is not > like we used to return the number of bytes written in size_t but we > realized that we never write mroe than INTMAX and narrowed the > return type to "int". > > In other words, returning "int" is not the most important thing in > this change. What is more important is that the function will > eventually signal success/failure with its return value. I suppose "return int" is what I meant, but this is probably better: midx: return success/failure in chunk write methods Thanks, -Stolee
