On Wed, Dec 2, 2020 at 2:50 AM Jeff King <peff@xxxxxxxx> wrote: > > > I don't see it being invoked anywhere, > > > > It is invoked in `t/t0032-reftable-unittest.sh`: > > https://github.com/dscho/git/blob/reftable-on-windows/t/t0032-reftable-unittest.sh > > Ah, thank you. I was looking at what Junio has queued in hn/reftable. > > > > but presumably if we were to add support to our test suite, we'd have a > > > script which invokes it within a scratch directory. > > > > I agree that it would make most sense for t0032 to prefix the call to > > `test-tool` with `TMPDIR=$PWD`. > > Yep, that would be fine. > > I'm not sure if the long-term goal is to have this opaque unit-test > program or not. If it is, I was likewise going to suggest that its > ad-hoc output be replaced with TAP. But it looks like on your branch > that "test-tool reftable" does not produce output at all. So I may be a > bit behind on what the current state and forward plans are... The most important requirement is that something fails if the unittests don't work. I surmised that that meant running tests from test-helper in some way, so this is what happens now. Looking for "unit.?test" across the git codebase didn't turn up much info. Happy to explore other solutions if you can give me pointers. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
