On Tue, Dec 1, 2020 at 8:01 PM Jeff King <peff@xxxxxxxx> wrote: > On Tue, Dec 01, 2020 at 05:25:53PM -0600, Felipe Contreras wrote: > > In this particular case there's no particular reason to just continue > > if there's no prefix. > > Right, which I already agreed with. > > I hesitated on responding at all, because you and I have not had a good > history of agreeing on commit messages. We don't have to agree. Having a different opinion is fine. In fact, that's precisely what keeps a project healthy: diversity of opinion. Do not hesitate. If you feel it must be said, say it. Or at least; don't hesitate on my behalf. I don't take disagreements personally. > But my comment was primarily for > other readers on the list. I do not want people blindly applying a rule > like "less indentation is good" without thinking about the code overall > (I don't know whether you thought about it or not, but it was not > apparent from your commit message). I see. I did think about it, but I couldn't find an instance in which such similar change could be contestable. "Why not do so?" was my succinct way of saying that: I cannot find any of the typical reasons why we might want to keep an indented condition. Sure, there's possibly better ways to state that, but I couldn't think of any in the limited time I devoted to the commit message. Maybe: "There's no reason to keep the main conditional branch indented; we can invert the condition and not continue". Cheers. -- Felipe Contreras
