Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes: > On Tue, Dec 1, 2020 at 4:12 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: >> The ctime_r() and asctime_r() functions are reentrant, but have >> no check that the buffer we pass in is long enough (the manpage says it >> "should have room for at least 26 bytes"). Since this is such an >> easy-to-get-wrong interface, and since we have the much safer stftime() >> as well as its more conveinent strbuf_addftime() wrapper, let's ban both >> of those. > > This still needs a s/conveinent/convenient/ mentioned earlier[1]. AH, thanks, fixed.
