Hi Han-Wen, On Mon, 30 Nov 2020, Han-Wen Nienhuys wrote: > On Sat, Nov 28, 2020 at 7:44 AM Johannes Schindelin via GitGitGadget > <gitgitgadget@xxxxxxxxx> wrote: > > > > These patches fix the PR build failures at > > https://github.com/git/git/pull/847/checks?check_run_id=1460683728, and are > > designed to be squashed into the 16 patches of the libreftable v3 patch > > series as submitted at > > https://lore.kernel.org/git/pull.847.v3.git.git.1606419752.gitgitgadget@xxxxxxxxx/ > > . > > > > A smaller form of the first patch was offered on the mailing list on May > > 4th: > > https://lore.kernel.org/git/ff60fde10919b6b8c54ecb8f38b710fac37624e3.1588599086.git.gitgitgadget@xxxxxxxxx/ > > . The next three patches were presented to the mailing list on October 2nd: > > https://lore.kernel.org/git/nycvar.QRO.7.76.6.2010021555290.50@xxxxxxxxxxxxxxxxx/ > > , and > > https://lore.kernel.org/git/nycvar.QRO.7.76.6.2010021557570.50@xxxxxxxxxxxxxxxxx/ > > . Some of the patches required slight adjustments to accommodate for context > > changes. > > > > Going forward, I would like to avoid the impression that it is the > > responsibility of the Git for Windows maintainer to keep the CI build > > passing on Windows. I am happy to assist in case it is unclear how to fix > > certain issues. I am not happy having to implement and test those fixes > > myself. How can we ensure this doesn't happen in the future? > > Thanks for the build system fix. I think it's OK to leave it to me to > solve the logic problems in the C code that you found. > > Would you mind if I massaged these contributions directly back into > github.com/google/reftable? Whatever works best for you. > Google has a corporate CLA from Microsoft, it's OK to accept this from > you. For better or worse, this is still where I'm developing reftable, > until it has landed in git-core. Ciao, Dscho
