On Fri, Nov 27, 2020 at 11:25 AM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > Not for this series, but I wonder if the eventual integration into the > i18n framework in git needs some thought, seems all the (including > presumably stuff show to users) UI strings are hardcoded English at the > moment. AFAIK, these are the only strings that potentially show up in the UI. If these strings need to be i18n'd. It is probably easier for git-core to provide its own version of reftable_error_str() ? Or we could remove reftable_error_str from the official API? -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado