On Tue, Nov 24, 2020 at 04:53:44PM -0800, Jonathan Tan wrote:
> > +static void store_selected(struct bb_commit *ent, struct commit *commit)
> > +{
> > + struct bitmapped_commit *stored = &writer.selected[ent->idx];
> > + khiter_t hash_pos;
> > + int hash_ret;
> > +
> > + /*
> > + * the "reuse bitmaps" phase may have stored something here, but
> > + * our new algorithm doesn't use it. Drop it.
> > + */
> > + if (stored->bitmap)
> > + ewah_free(stored->bitmap);
>
> I tried to figure out how the "reuse bitmaps" phase stores things in
> this field, but that led me down a rabbit hole that I didn't pursue.
> But anyway, the new bitmap is correctly generated, so clearing the old
> bitmap is safe (except, possibly, wasting time, but I see that in a
> subsequent patch, existing bitmaps will be reused in a new wawy).
Yep. The existing reuse mechanism is thrown out in a later patch.
> Thanks - overall this looks straightforward.
Thanks for taking a look! Very much appreciated.
Taylor
