On Tue, Nov 24, 2020 at 05:17:48PM -0800, Jonathan Tan wrote:
> > From: Derrick Stolee <dstolee@xxxxxxxxxxxxx>
> >
> > The current rev-list tests that check the bitmap data only work on HEAD
> > instead of multiple branches. Expand the test cases to handle both
> > 'master' and 'other' branches.
>
> [snip]
>
> > +rev_list_tests () {
> > + state=$1
> > +
> > + for branch in "master" "other"
>
> Would it be worth including "HEAD" in the list here? It would make more
> sense with the commit message saying "exstend" instead of "replace".
I don't think so. These tests were run with master checked out, so
testing HEAD would be no different than including "master" in the list
of branches here, so the commit message is correct that this is an
extension, too.
> [snip rest]
>
> The 2 prior patches (13 and 14) look good to me.
Thanks for taking a look.
Thanks,
Taylor
