Re: [PATCH v3 04/16] reftable: add error related functionality

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 27, 2020 at 2:42 AM Han-Wen Nienhuys via GitGitGadget
<gitgitgadget@xxxxxxxxx> wrote:

> +/*
> + Errors in reftable calls are signaled with negative integer return values. 0
> + means success.
> +*/

This is the format of multi-line comments:

/*
* A very long
* multi-line comment.
*/

> +enum reftable_error {
> +       /* Unexpected file system behavior */
> +       REFTABLE_IO_ERROR = -2,
> +
> +       /* Format inconsistency on reading data
> +        */

No need for a multi-line comment here.

> +       REFTABLE_FORMAT_ERROR = -3,
> +
> +       /* File does not exist. Returned from block_source_from_file(),  because
> +          it needs special handling in stack.
> +       */

Once again, and for the rest of the file.

-- 
Felipe Contreras



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux