On Thu, Nov 26, 2020 at 02:28:51AM +0100, Ævar Arnfjörð Bjarmason wrote: > The preceding commit removed the use of the verify_tag() function, but > didn't remove this code to keep the diff smaller. Let's remove this > unused code now. I do appreciate keeping diffs readable, but IMHO this is making things more confusing, because you had to add a new dummy call to verify_tag() in the previous commit in order to keep the compiler from complaining about the unused static function (I'm actually surprised that it doesn't complain about the immediate "return 0" in that function, which makes the rest of the function unambiguously unreachable). -Peff
