On Tue, Nov 24, 2020 at 6:37 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > > +test_expect_success 'push with @' ' > > + > > + mk_test testrepo heads/master && > > + git checkout master && > > + git push testrepo @ && > > + check_push_result testrepo $the_commit heads/master > > + > > +' > > This is OK, but shouldn't this be placed before the tests with > various configuration? Something along the lines of the attached, > but with the body of the loop properly reindented, would also give > us a better test coverage at the same time. I don't see much value in those tests, since I don't see how if one passes another one would fail. But I guess it cannot hurt. -- Felipe Contreras
