"Marco Costalba" <mcostalba@xxxxxxxxx> writes: > On 8/16/07, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> "Marco Costalba" <mcostalba@xxxxxxxxx> writes: >> >> > Indeed &mrtree is passed to merge_trees() that not always >> > seems to set the value, so on some paths mrtree could >> > return uninitialized. >> > >> > Spotted by a gcc 4.2.1 warning >> >> Are you sure that gcc is correctly seeing the codeflow? >> >> In merge(), mrtree is used only under index_only, and >> merge_trees() always sets *result under index_only. >> > > Ok ;-) > > Now two options: > > - discard the patch > > - change the title in 'silence a gcc bougus warning' Third option. Change the assignment from "mrtree = NULL" to "mrtree = mtree". It is a standard idiom to work around stupid gcc warnings. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
