On 23.11.20 21:50, serg.partizan@xxxxxxxxx wrote: > > > On Mon, Nov 23, 2020 at 20:03, Stefan Haller <stefan@xxxxxxxxxxxxxxxx> > wrote: >> The problem is that it needs to be recalculated when the >> theme changes, and I have trouble testing that because the >> <<ThemeChanged>> event doesn't appear to be sent on Mac, as far as I can >> see. > > How are you testing this? By changing the Appearance setting from Light to Dark or back in Mac's preferences window. The git gui window does update dynamically when you do this. However, I think I was wrong when I assumed that this would change the theme; there's only one theme on Mac, the "aqua" theme. It just changes its colors, it seems. > So you can safely put your code inside "color::sync_with_theme". Will do; I'll send out v2 in a moment. > And We should move call to sync_with_theme from git-gui.sh into > InitTheme. I don't know why I have not put it there before. Yes, I was wondering this too. But as it doesn't seem to make a difference in practice, I'll leave this for someone else to fix at some point.
