On 11/17/2020 6:36 PM, Eric Sunshine wrote:
> On Tue, Nov 17, 2020 at 09:13:14PM +0000, Derrick Stolee via GitGitGadget wrote:
>> Updates in V4
>> =============
>> * Eric did an excellent job providing a patch that cleans up several parts
>> of my series. The most impressive is his mechanism for testing the
>> platform-specific Git logic in a way that is (mostly) platform-agnostic.
>>
>> * Windows doesn't have the 'id' command, so we cannot run the macOS
>> platform test on Windows.
>
> This is easy to resolve. Drop in the following patch and then replace
> the `$(id -u)` invocation in the test with `$(test-tool getuid)`.
> This way, the test should work on any platform since both
> launchctl_get_uid() and `test-tool` will retrieve identical values for
> UID.
I was giving your 'test-tool getuid' idea a try, and found that _also_
the $HOME environment variable differs from the format we expect in these
subcommands:
$HOME: C:\...
argument in subcommand: /c/...
So, there is another reason why these tests don't work on Windows. I'm
of the opinion that maybe it's not worth _that_ level of cross-platform
testing.
Unless I'm missing something simple about a $HOME alternative here, this
seems to be more work than the resulting value. Personally, I'm happy
with the benefit you've already provided in allowing Linux to test all
platforms.
Thanks,
-Stolee
