From: Derrick Stolee <dstolee@xxxxxxxxxxxxx> The --replace-all option was added in 4ddba79d (git-config-set: add more options) but was not tested along with the 'value_regex' parameter. Since we will be updating this option to optionally treat 'value_regex' as a fixed string, let's add a test here that documents the current behavior. Signed-off-by: Derrick Stolee <dstolee@xxxxxxxxxxxxx> --- t/t1300-config.sh | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/t/t1300-config.sh b/t/t1300-config.sh index 19836ec83b..8783767d4f 100755 --- a/t/t1300-config.sh +++ b/t/t1300-config.sh @@ -1946,4 +1946,18 @@ test_expect_success 'set all config with value_regex' ' test_cmp expect actual ' +test_expect_success '--replace-all and value_regex' ' + rm -f config && + git config --file=config --add abc.key one && + git config --file=config --add abc.key two && + git config --file=config --add abc.key three && + git config --file=config --replace-all abc.key four "o+" && + git config --file=config --list >actual && + cat >expect <<-\EOF && + abc.key=four + abc.key=three + EOF + test_cmp expect actual +' + test_done -- gitgitgadget