Users of the grep machinery need to call `init_grep_defaults()` to populate some defaults. There's a comment: "We could let the compiler do this, but without C99 initializers the code gets unwieldy and unreadable, so...". We have such initializers now, so we can simplify accordingly. Martin Ågren (4): grep: don't set up a "default" repo for grep grep: use designated initializers for `grep_defaults` grep: simplify color setup MyFirstObjectWalk: drop `init_walken_defaults()` Documentation/MyFirstObjectWalk.txt | 34 +------------ grep.h | 1 - builtin/grep.c | 1 - builtin/log.c | 1 - grep.c | 74 ++++++++++------------------- revision.c | 1 - 6 files changed, 27 insertions(+), 85 deletions(-) -- 2.29.2.454.gaff20da3a2