From: Derrick Stolee <dstolee@xxxxxxxxxxxxx> The --replace-all option was added in 4ddba79d (git-config-set: add more options) but was not tested along with the 'value_regex' parameter. Since we will be updating this option to optionally treat 'value_regex' as a fixed string, let's add a test here that documents the current behavior. Signed-off-by: Derrick Stolee <dstolee@xxxxxxxxxxxxx> --- t/t1300-config.sh | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/t/t1300-config.sh b/t/t1300-config.sh index ef56b08070..74e0f84c0a 100755 --- a/t/t1300-config.sh +++ b/t/t1300-config.sh @@ -1949,4 +1949,20 @@ test_expect_success 'set all config with value_regex' ' test_cmp expect .git/config ' +test_expect_success '--replace-all and value_regex' ' + q_to_tab >.git/config <<-\EOF && + [abc] + Qkey = one + Qkey = two + Qkey = three + EOF + q_to_tab >expect <<-\EOF && + [abc] + Qkey = four + Qkey = three + EOF + git config --replace-all abc.key four "o+" && + test_cmp expect .git/config +' + test_done -- gitgitgadget