Hi Junio, On Mon, 16 Nov 2020, Junio C Hamano wrote: > "Johannes Schindelin via GitGitGadget" <gitgitgadget@xxxxxxxxx> > writes: > > > From: Johannes Schindelin <johannes.schindelin@xxxxxx> > > > > The `set-env` construct was deprecated as of the announcement in > > https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ > > ... > > diff --git a/.github/workflows/check-whitespace.yml b/.github/workflows/check-whitespace.yml > > index 9d070b9cdf..c74b47de9e 100644 > > --- a/.github/workflows/check-whitespace.yml > > +++ b/.github/workflows/check-whitespace.yml > > @@ -14,7 +14,7 @@ jobs: > > steps: > > - name: Set commit count > > shell: bash > > - run: echo "::set-env name=COMMIT_DEPTH::$((1+$COMMITS))" > > + run: echo "COMMIT_DEPTH=$((1+$COMMITS))" >>$GITHUB_ENV > > env: > > COMMITS: ${{ github.event.pull_request.commits }} > > Do we need something similar for ci/print-test-failures.sh to > prevent failures like https://github.com/git/git/runs/1409815807? > > Perhaps like the following (which is copied-and-pasted without > understanding what is going on or without doing nothing more than > skimming [*1*])? Yes, of course, this precisely what we need. Sorry for not even _thinking_ about `git grep set-env`. This seems the only remaining use of that construct in our workflows, though. Thanks, Dscho > > > Reference > > *1* https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#setting-an-environment-variable > > > ci/print-test-failures.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git c/ci/print-test-failures.sh w/ci/print-test-failures.sh > index 92a983a265..c70d6cdbf2 100755 > --- c/ci/print-test-failures.sh > +++ w/ci/print-test-failures.sh > @@ -48,7 +48,7 @@ do > ;; > github-actions) > mkdir -p failed-test-artifacts > - echo "::set-env name=FAILED_TEST_ARTIFACTS::t/failed-test-artifacts" > + echo "FAILED_TEST_ARTIFACTS=t/failed-test-artifacts" >>$GITHUB_ENV > cp "${TEST_EXIT%.exit}.out" failed-test-artifacts/ > tar czf failed-test-artifacts/"$test_name".trash.tar.gz "$trash_dir" > continue > >
